LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  February 2014

HPS-SOFTWARE February 2014

Subject:

Re: Ecal monitoring

From:

"McCormick, Jeremy I." <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Wed, 26 Feb 2014 10:43:47 -0800

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (1 lines)

Hi,

I would not be too hesitant to commit code to the repository, because older file revisions are easily retrieved.  If you break something, then the trunk copy can be replaced with an older revision.  That doesn't mean you should commit code that does not compile though so always build locally the file revisions you are going to checkin to the repository.

Also, checking with the author of the original class about your modifications is not a bad idea before you change it.  They might have some opinions about it.

By the way, I have tried to make a new package that would contain monitoring drivers.  It is found at trunk/monitoring-drivers so if you're going to make new ones then put them there.  There are currently two classes in that module, one for SVT and another for ECal, that have some basic plots.  Feel free to add to those and checkin to the SVN.  My preference is moving development of monitoring drivers to that package instead of hps-java.

--Jeremy

-----Original Message-----
From: [log in to unmask] [mailto:[log in to unmask]] On Behalf Of Andrea Celentano
Sent: Wednesday, February 26, 2014 4:31 AM
To: Gabriel CHARLES
Cc: hps-software
Subject: Re: Ecal monitoring

Hi Gabriel,
thanks.
Why you suggest to not commit the EcalHitPlots in the case I modify it (I have not done it!)?
I mean, the idea I have is that when you work on a piece of the software, at a certain point it will be part of the "hps-software".
How is this managed? Who is responsible to decide when a certain "part" 
will be inserted in the main trunk?
I ask this because I prefer to know this in advance, before starting the real work, in order to not have to re-do later one.

Thanks!

Andrea

Il 02/26/2014 01:16 PM, Gabriel CHARLES ha scritto:
> Hi Andrea,
>
>   I think you can do both but respecting different conditions.
>
>   If you modify EcalHitPlots and do not commit it, no one will see it, 
> so you can do whatever you want, but you must be sure you won't commit 
> it by mistake and organize your own backup. It is not what I would 
> recommend.
>
>   If you create a new class and want to commit it, you can create it
> here: "src.main.java.org.lcsim.hps.users.acelentano", for me it is 
> located in the java trunk, and there is a folder "users". I think this 
> is the prefered solution because you can share it with other if needed.
>
>   If it can help, when you create your own PlotsDriver without any 
> option you can call it from the steering file this way:
>
>         <driver name="YourDriverName"/>
>
>         <driver name="YourDriverName" 
> type="org.lcsim.hps.users.acelentano.PlotsDriver">
>         </driver>
>
> Hope it helps,
> ---
> Gabriel CHARLES
> Institut de Physique Nucléaire d'Orsay
>
> On Wed, 26 Feb 2014 12:22:39 +0100, Andrea Celentano wrote:
>> Dear all,
>> a stupid question about the "proper/standard/hps-defined/.." way to 
>> proceed for the Ecal monitoring:
>>
>> - I see there is a class org.lcsim.hps.ecal.monitoring.EcalHitPlots
>> that implements (some) of the plots I'd like to add.
>> - Should I modify it, adding what I need OR -Should I create a new 
>> class, modify the steering file accordingly (and eventually copying 
>> the pieces of code I need from EcalHitPlots)?
>>
>> Thanks
>>
>> Andrea
>>
>>
>> #####################################################################
>> ###
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

May 2024
April 2024
March 2024
February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use