LISTSERV mailing list manager LISTSERV 16.5

Help for XROOTD-DEV Archives


XROOTD-DEV Archives

XROOTD-DEV Archives


XROOTD-DEV@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

XROOTD-DEV Home

XROOTD-DEV Home

XROOTD-DEV  January 2021

XROOTD-DEV January 2021

Subject:

[xrootd/xrootd] 8e84fe: XrdTpc: Factor out recursive writes.

From:

Andrew Hanushevsky <[log in to unmask]>

Reply-To:

xrootd developers' list for Scalla/xrootd repository and related issues <[log in to unmask]>

Date:

Sun, 31 Jan 2021 22:45:28 -0800

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (106 lines)

  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 8e84fe4106b777b3351878d8c4af74a431cac2d6
      https://github.com/xrootd/xrootd/commit/8e84fe4106b777b3351878d8c4af74a431cac2d6
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.cc
    M src/XrdTpc/XrdTpcStream.hh

  Log Message:
  -----------
  XrdTpc: Factor out recursive writes.

This separates the writing methods of the stream to avoid potential
recursion when dumping buffered data.  This also allows the buffer
to accept partial data so the beginning offset of the buffer is
always a multiple of the buffer size (i.e., the buffer offsets
always stay MB-aligned).

With this, a single incoming buffer from curl may be split across
two entries in order to keep alignment.


  Commit: f8970471e06da3e1dee53b1f62df54ca001deed5
      https://github.com/xrootd/xrootd/commit/f8970471e06da3e1dee53b1f62df54ca001deed5
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.hh

  Log Message:
  -----------
  XrdTpc: Do not allow partial buffer writes

The multistream code uses an occupied buffer as an indication that
a request is ongoing; for now, we can't do partial buffer writes
as this causes the back-off code to think the buffer is free and
start too many requests.


  Commit: 3d28dd50dc1e467d3fbb83d77a2144b22fa4c74a
      https://github.com/xrootd/xrootd/commit/3d28dd50dc1e467d3fbb83d77a2144b22fa4c74a
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcTPC.cc
    M src/XrdTpc/XrdTpcTPC.hh

  Log Message:
  -----------
  XrdTpc: Adjust buffer size based on number of streams.

As we only write when buffers are full and we don't need a full 16MB
buffer when we are doing single-streams (for single stream, we're only
waiting to accumulate a "large-enough" MB-aligned buffer), we can
simply decrease the buffer size.  Saves some allocated-but-unused
space.


  Commit: 3b40aa1163db5044be7b38f5a76dac03610e557f
      https://github.com/xrootd/xrootd/commit/3b40aa1163db5044be7b38f5a76dac03610e557f
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.cc

  Log Message:
  -----------
  XrdTpc: Always populate error buffer with messages.

Even when there's an internal logic error, make sure the Write
method populates the error message - if nothing else, will be useful
for debugging.


  Commit: defdc085cddcd11f30d3b89d7af8a54394c272d0
      https://github.com/xrootd/xrootd/commit/defdc085cddcd11f30d3b89d7af8a54394c272d0
  Author: Andrew Hanushevsky <[log in to unmask]>
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.cc
    M src/XrdTpc/XrdTpcStream.hh
    M src/XrdTpc/XrdTpcTPC.cc
    M src/XrdTpc/XrdTpcTPC.hh

  Log Message:
  -----------
  Merge pull request #1391 from bbockelm/xrdtpc_stream_write_refactor

XrdTPC: Refactor stream writes


Compare: https://github.com/xrootd/xrootd/compare/a31d667f02a6...defdc085cddc

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
December 2010
November 2010
October 2010
September 2010

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use